activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1626) Disable thread leak check for failing tests
Date Mon, 22 Jan 2018 16:39:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334519#comment-16334519
] 

ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------

Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1800
  
    @franz1981 If the test fails, whether cleanly or not, we get reported and should fix it.
The leakage is not important here. After you fix it and it begin to pass, the thread check
rule will perform check on it, making sure it doesn't leak threads. Let's say there are 2
situations:
    
    1) first test passes but secretly leaking threads and caused second test fail.
    2) first test failed and also leaking thread and caused second test fail.
    
    IMO the case 1) would be much harder to debug. So in case 1) the first test should be
checked to make sure it doesn't pollute others. In case 2) however, you know the first test
failed and you can be sure it fails on its own, there for a real failure. So no matter how
many more failures follow, you will have to fix the first failure first. Once it passes, the
thread check rule kicks in to make sure the leak won't happen.



> Disable thread leak check for failing tests
> -------------------------------------------
>
>                 Key: ARTEMIS-1626
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message