activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ARTEMIS-1626) Disable thread leak check for failing tests
Date Mon, 22 Jan 2018 16:22:00 GMT


ASF GitHub Bot commented on ARTEMIS-1626:

Github user gaohoward commented on the issue:
    @clebertsuconic @mtaylor @franz1981 We shouldn't disable the thread check for all tests.
What this PR do it selectively disable the check for failing tests. If a test passes the check
is certainly on, to make sure it silently leaking and affects other tests.

> Disable thread leak check for failing tests
> -------------------------------------------
>                 Key: ARTEMIS-1626
>                 URL:
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.0
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.

This message was sent by Atlassian JIRA

View raw message