activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1609) Restore ability to configure "name" of ActiveMQDestination
Date Wed, 17 Jan 2018 15:54:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328906#comment-16328906
] 

ASF GitHub Bot commented on ARTEMIS-1609:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r162092404
  
    --- Diff: tests/compatibility-tests/src/main/resources/serial/jbmserial.groovy ---
    @@ -49,6 +50,11 @@ if (method.equals("write")) {
         topic = new ActiveMQTopic("topic")
         temporary = ActiveMQDestination.createTemporaryQueue("whatever")
         temporaryTopic = ActiveMQDestination.createTemporaryTopic("whatever")
    +    if (version.equals("ARTEMIS-SNAPSHOT")) {
    +        destination = new ActiveMQDestination("address", "name", ActiveMQDestination.TYPE.DESTINATION,
null)
    --- End diff --
    
    This is for backwards compatibility. We need to use the field to validate the older format.
it's good to be here.


> Restore ability to configure "name" of ActiveMQDestination
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-1609
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1609
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message