activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1609) Restore ability to configure "name" of ActiveMQDestination
Date Wed, 17 Jan 2018 08:23:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328457#comment-16328457
] 

ASF GitHub Bot commented on ARTEMIS-1609:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161981000
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
    @@ -277,6 +305,7 @@ public void setSimpleAddress(SimpleString address) {
           if (address == null) {
              throw new IllegalArgumentException("address cannot be null");
           }
    +      this.address = address.toString();
    --- End diff --
    
    should also make it set deprecated name field.


> Restore ability to configure "name" of ActiveMQDestination
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-1609
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1609
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message