activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1601) NPE silently thrown in StompSession#sendMessage
Date Thu, 11 Jan 2018 16:01:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322454#comment-16322454
] 

ASF GitHub Bot commented on ARTEMIS-1601:
-----------------------------------------

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1772
  
    I'm not sure this is actually necessary.  `java.lang.NullPointerException` extends `java.lang.RuntimeException`
which in turn extends `java.lang.Exception` which is already being caught for this `try` block
and returning 0.


> NPE silently thrown in StompSession#sendMessage
> -----------------------------------------------
>
>                 Key: ARTEMIS-1601
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1601
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: STOMP
>    Affects Versions: 2.4.0
>         Environment: Artemis 2.5.0-SNAPSHOT
>            Reporter: Johan Stenberg
>            Assignee: Justin Bertram
>            Priority: Minor
>
> During debugging a stomp session I realized that the StompSession's send method does
not check if looking up a subscription returns null:
> {code:java}
> StompSubscription subscription = subscriptions.get(consumer.getID());
> {code}
> This later sometimes results NPEs at:
> {code:java}
> if (subscription.getAck().equals(Stomp.Headers.Subscribe.AckModeValues.AUTO)) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message