activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java
Date Wed, 03 Jan 2018 03:27:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309095#comment-16309095
] 

ASF GitHub Bot commented on ARTEMIS-1406:
-----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1745


> FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java
> ---------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1406
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362      try {
> 363         close();
> 364      } catch (Exception e) {
>    	
> CID 1418586 (#1 of 1): BC: Bad casts of object references (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException can't be a java.io.IOException.
> 365         if (e instanceof IOException) {
> 366            factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), e), e.getMessage(),
this);
> 367         }
> 368         throw e;
> 369      }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message