activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1399) FindBugs: Comparing incompatible types for equality in QueueFilterPredicate.java
Date Tue, 23 Jan 2018 21:15:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336379#comment-16336379
] 

ASF subversion and git services commented on ARTEMIS-1399:
----------------------------------------------------------

Commit 98cf8651cf1976b87b2b7acc323562fdc680124f in activemq-artemis's branch refs/heads/master
from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=98cf865 ]

ARTEMIS-1399 fix comparison


> FindBugs: Comparing incompatible types for equality in QueueFilterPredicate.java
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1399
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1399
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>         Environment: commit 53a9c9b47b8c64ff2c0f2c6be40a1cf5984e5e8b (HEAD -> master,
upstream/master)
> Merge: 49ef04b6f d2dcf1bba
> Author: Clebert Suconic <clebertsuconic@apache.org>
> Date:   Wed Sep 6 10:30:13 2017 -0400_
>            Reporter: Jiri Daněk
>            Assignee: Justin Bertram
>            Priority: Minor
>
> {noformat}
>             case CONSUMER_ID:
>                Queue q = server.locateQueue(new SimpleString(queue.getName()));
>                for (Consumer consumer : q.getConsumers()) {
>                   if (value.equals(consumer.sequentialID()))
>                      return true;
>                }
>                return false;
> {noformat}
> see at https://github.com/apache/activemq-artemis/blob/133dd4377309932787152a91c932c2f23c4dd212/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/predicate/QueueFilterPredicate.java#L56
> Does not look hard to fix, but the error handling is not straightforward (is it ok to
swallow invalid input and simply find nothing if the user does not give valid ID? probably
yes... What to do if user asks comparing operation "CONTAINS" and not "EQUALS"? Does that
mean return queues where the given ID is one of the consumers/the sole consumer?)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message