activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1241) Auto create does not work for FQQN queues
Date Wed, 17 Jan 2018 13:22:05 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328753#comment-16328753
] 

ASF GitHub Bot commented on ARTEMIS-1241:
-----------------------------------------

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1759#discussion_r162047806
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
    @@ -194,7 +195,14 @@ private boolean checkAutoCreateQueue(SimpleString queueName, boolean
isTemporary
              try {
                 if (!queueBinding.isExists()) {
                    if (bindingQuery.isAutoCreateQueues()) {
    -                  server.createQueue(queueName, RoutingType.ANYCAST, queueName, null,
true, isTemporary);
    +                  SimpleString queueNameToUse = queueName;
    +                  SimpleString addressToUse = queueName;
    +                  if (CompositeAddress.isFullyQualified(queueName.toString())) {
    +                     CompositeAddress compositeAddress = CompositeAddress.getQueueName(queueName.toString());
    +                     addressToUse = new SimpleString(compositeAddress.getAddress());
    +                     queueNameToUse = new SimpleString(compositeAddress.getQueueName());
    +                  }
    --- End diff --
    
    server.createQueue() will create the address if it doesn't already exist.  


> Auto create does not work for FQQN queues
> -----------------------------------------
>
>                 Key: ARTEMIS-1241
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1241
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>            Assignee: Gary Tully
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message