Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 405C8200D53 for ; Tue, 5 Dec 2017 13:16:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3EEAF160C1D; Tue, 5 Dec 2017 12:16:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 84C78160C0A for ; Tue, 5 Dec 2017 13:16:04 +0100 (CET) Received: (qmail 70008 invoked by uid 500); 5 Dec 2017 12:16:03 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 69999 invoked by uid 99); 5 Dec 2017 12:16:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 12:16:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0D0AF1A126E for ; Tue, 5 Dec 2017 12:16:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HkmXpBYsLHib for ; Tue, 5 Dec 2017 12:16:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 041245F2F1 for ; Tue, 5 Dec 2017 12:16:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B89E3E0E80 for ; Tue, 5 Dec 2017 12:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 349ED255CA for ; Tue, 5 Dec 2017 12:16:00 +0000 (UTC) Date: Tue, 5 Dec 2017 12:16:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1535) AMQP transaction sends settle after disposition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 05 Dec 2017 12:16:05 -0000 [ https://issues.apache.org/jira/browse/ARTEMIS-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278460#comment-16278460 ] ASF GitHub Bot commented on ARTEMIS-1535: ----------------------------------------- GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1687 ARTEMIS-1535 - settle delivery in same lock as sending the disposition https://issues.apache.org/jira/browse/ARTEMIS-1535 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-1535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1687.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1687 ---- commit 21e572c5816850d6c72b82d62e80114aec363a0b Author: Andy Taylor Date: 2017-12-05T12:12:54Z ARTEMIS-1535 - settle delivery in same lock as sending the disposition https://issues.apache.org/jira/browse/ARTEMIS-1535 ---- > AMQP transaction sends settle after disposition > ----------------------------------------------- > > Key: ARTEMIS-1535 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1535 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP > Affects Versions: 2.4.0 > Reporter: Andy Taylor > Assignee: Andy Taylor > Fix For: 2.5.0 > > > This is a race condition, the ProtonTransactionHandler should settle whilst in the same lock as the disposition being sent -- This message was sent by Atlassian JIRA (v6.4.14#64029)