activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1540) Missing management annotations
Date Fri, 08 Dec 2017 00:07:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282772#comment-16282772
] 

ASF GitHub Bot commented on ARTEMIS-1540:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1689#discussion_r155675756
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
---
    @@ -631,7 +631,9 @@ default Message setAnnotation(SimpleString key, Object value) {
        default Map<String, Object> toPropertyMap() {
           Map map = new HashMap<>();
           for (SimpleString name : getPropertyNames()) {
    -         map.put(name.toString(), getObjectProperty(name.toString()));
    +         //some property is SimpleString, which is not available for management console
    +         Object value = getObjectProperty(name.toString());
    +         map.put(name.toString(), value == null ? null : value.toString());
    --- End diff --
    
    nice catch.


> Missing management annotations
> ------------------------------
>
>                 Key: ARTEMIS-1540
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1540
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 2.5.0
>
>
> Some of the management operations are not properly annotated.
> Also need to add an Operation to list divert names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message