activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1537) Broker is less strict with parsing when reloading config than when parsing it on startup
Date Fri, 08 Dec 2017 07:48:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283169#comment-16283169
] 

ASF GitHub Bot commented on ARTEMIS-1537:
-----------------------------------------

Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1688#discussion_r155719121
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
    @@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream input) throws
Exception {
           String xml = XMLUtil.readerToString(reader);
           xml = XMLUtil.replaceSystemProps(xml);
           Element e = XMLUtil.stringToElement(xml);
    -
    +      NodeList children = e.getElementsByTagName("core");
    --- End diff --
    
    Yes, that seems better than my solution. I wanted to use the same process while reloading
conf. as parsing conf. when starting broker (https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/FileDeploymentManager.java#L85).



> Broker is less strict with parsing when reloading config than when parsing it on startup
> ----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1537
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1537
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Stanislav Knot
>            Priority: Minor
>
> 1) Start broker with default config.
> 2) Edit the <addresses> section in broker.xml with bad element
> 3) Save the config and observe successful reload in log. (The new configuration is applied.
Had there be new addresses configured, for example, they would've been created.)
> 4) Finally, stop and start again the broker. Notice that the string blah blah now causes
a failure on startup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message