activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1532) Enable tests which are unintentionally skipped by surefire
Date Sun, 03 Dec 2017 22:54:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276146#comment-16276146
] 

ASF GitHub Bot commented on ARTEMIS-1532:
-----------------------------------------

GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1683

    ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire 

    This is not ready to be merged, because `HAAutomaticBackupSharedStoreTest` and `testSystemPropertyOverride`
are failing after these changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_skipped_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1683
    
----
commit 63cdbc4c26cbd419a8303a8b9796a0cdf4613b99
Author: Jiri Danek <jdanek@redhat.com>
Date:   2017-12-03T18:44:58Z

    ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire
    
    These tests used to have a wrong name, so they weren't executed by
    Surefire during a `mvn test` run.
    
    After enablement, the following tests are now failing:
    
    org.apache.activemq.artemis.tests.integration.cluster.ha.HAAutomaticBackupSharedStoreTest
    org.apache.activemq.artemis.tests.integration.ra.OutgoingConnectionNoJTATest

commit 380980b2c58a716cdbf8b81b2f5a9cba080d16c6
Author: Jiri Danek <jdanek@redhat.com>
Date:   2017-12-03T18:56:47Z

    ARTEMIS-1532 Fix OutgoingConnectionNoJTATest

----


> Enable tests which are unintentionally skipped by surefire
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-1532
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1532
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: Broker, STOMP
>    Affects Versions: 1.5.6, 2.5.0
>            Reporter: Jiri Daněk
>            Assignee: Justin Bertram
>
> Some tests, e.g. {{org.apache.activemq.artemis.tests.integration.stomp#StompTestWithInterceptors}}
are not being run by Maven.
> This is because by default the Surefire Maven plugin searches for tests in classes with
a certain name pattern. These tests are not named to conform to this pattern. https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html
> There are some tests which have a conforming name, but it is not *Test.java, which seems
to be the chosen Artemis convention. These are
> {noformat}
> org.apache.activemq.advisory.AdvisoryTests
> org.apache.activemq.artemis.tests.integration.amqp.TopicDurableTests
> org.apache.activemq.usecases.DurableSubscriptionHangTestCase
> org.apache.activemq.usecases.TestBrokerConnectionDuplexExcludedDestinations
> org.apache.activemq.artemis.tests.smoke.expire.TestSimpleExpire
> {noformat}
> CC [~clebertsuconic]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message