Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 61DE8200D3E for ; Thu, 16 Nov 2017 13:53:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 60597160BE6; Thu, 16 Nov 2017 12:53:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7210160BE5 for ; Thu, 16 Nov 2017 13:53:11 +0100 (CET) Received: (qmail 81994 invoked by uid 500); 16 Nov 2017 12:53:10 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 81985 invoked by uid 99); 16 Nov 2017 12:53:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 12:53:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 006ECC5446 for ; Thu, 16 Nov 2017 12:53:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7HtLKAR_dZcC for ; Thu, 16 Nov 2017 12:53:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D5B4F60F78 for ; Thu, 16 Nov 2017 12:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85113E259D for ; Thu, 16 Nov 2017 12:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C923B24106 for ; Thu, 16 Nov 2017 12:53:00 +0000 (UTC) Date: Thu, 16 Nov 2017 12:53:00 +0000 (UTC) From: "Christopher L. Shannon (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (AMQ-6858) Fix several durable subscription bridge propagation issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 16 Nov 2017 12:53:12 -0000 [ https://issues.apache.org/jira/browse/AMQ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon resolved AMQ-6858. ----------------------------------------- Resolution: Fixed Fix Version/s: 5.15.3 I'm going to close this as resolved. Everything seems to be working as intended. I merged the commits back to 5.15.3 as this is just a bunch of bug fixes and not a new feature. > Fix several durable subscription bridge propagation issues > ---------------------------------------------------------- > > Key: AMQ-6858 > URL: https://issues.apache.org/jira/browse/AMQ-6858 > Project: ActiveMQ > Issue Type: Bug > Components: Broker, networkbridge > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Fix For: 5.16.0, 5.15.3 > > > While testing bridging together 3 or more brokers I discovered several problems specifically related to durable subscription propagation. In general durable network subscriptions were not propagating properly when using more than 2 brokers either by not being created at all, not being removed, or even in some cases the same durable was being added twice and causing bridge failures. > This jira includes the following changes to fix these issues: > # Currently proxy network subscriptions are not eligible to be conduit. For topics it doesn't make sense to not use conduit subscriptions so this should be changed. For queue subscriptions this can sometimes be useful to conduit as well so I added a new flag for this. Not allowing conduit topic proxy network subs was causing collisions with durables and breaking bridges > # The durable sync process should only ignore network durable subs for the specific bridge it is syncing, it should still be re-adding subs for other bridges otherwise they will get dropped > # On demand subscription removal, the tracked demand sub should be checked to see if it's a network demand sub and if it still has remote durable subs attached to it. If it does they need to be cleaned up and removed > # Lastly, when creating a demand subscription the consumerId should only be changed if the consumer is for a direct bridge and not a proxy bridge otherwise the demand won't be properly tracked and removed later -- This message was sent by Atlassian JIRA (v6.4.14#64029)