activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1516) Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
Date Fri, 17 Nov 2017 06:41:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256554#comment-16256554
] 

ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612327
  
    --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/referenceable/ActiveMQRAConnectionFactoryObjectFactory.java
---
    @@ -27,7 +27,7 @@
      *
      * Given a reference - reconstructs an ActiveMQRAConnectionFactory
      */
    -public class ConnectionFactoryObjectFactory implements ObjectFactory {
    +public class ActiveMQRAConnectionFactoryObjectFactory implements ObjectFactory {
    --- End diff --
    
    was a tidy up, again not needed but just being explicit. we can rename and extend.


> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1516
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI serialisation needs
to use StringRefAddr to support this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message