activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1516) Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
Date Fri, 17 Nov 2017 06:39:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256550#comment-16256550
] 

ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1659#discussion_r151612096
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
    @@ -88,20 +83,6 @@
     
        private boolean finalizeChecks;
     
    -   @Override
    -   public void writeExternal(ObjectOutput out) throws IOException {
    -      URI uri = toURI();
    -
    -      try {
    -         out.writeUTF(uri.toASCIIString());
    --- End diff --
    
    No it is serialising fine, in fact this is what tomcat resources is doing, this is exactly
what we are purposely changing to fix the issue, it needs to serialise into an array of StringRefAddr
(properties).


> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1516
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI serialisation needs
to use StringRefAddr to support this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message