activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1516) Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
Date Fri, 17 Nov 2017 01:18:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256266#comment-16256266
] 

ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1659
  
    The test failure is so weird. if you run the whole thing in Idea it fails.. individually
it's passing.
    
    
    I can see it's missing a property.. but I'm not sure what changed that user was at some
point considered a property.. as the BeanUtil wasn't picking up builder pattern on setUser...
so weird.
    
    
    Anyways.. I sent a PR to your branch.. please squash it.
    
    
    Only thing I'm concerned here is the wire change on the connection factory (as it was
a string with the URI before)... and I'm not so sure if you really need to move those classes..
thinking this as an API change since Wildfly will probably need it.


> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1516
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI serialisation needs
to use StringRefAddr to support this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message