activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1516) Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
Date Thu, 16 Nov 2017 19:24:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255822#comment-16255822
] 

ASF GitHub Bot commented on ARTEMIS-1516:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1659

    ARTEMIS-1516 - Ensure JNDI via Tomcat Resource works

    Apply fix so that when using JNDI via tomcat resource it works. 
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits
better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's
instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured
getters still behave the same

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1516

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1659
    
----
commit 8efb97b15fc7d488a1f371e27ccd3f27b4a33923
Author: Michael André Pearce <michael.andre.pearce@me.com>
Date:   2017-11-04T02:26:39Z

    ARTEMIS-1516 - Ensure JNDI via Tomcat Resource works
    
    Apply fix so that when using JNDI via tomcat resource it works. 
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits
better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's
instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured
getters still behave the same

----


> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1516
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1516
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>
> Ensure JNDI using Tomcat Resources works as like ActiveMQ 5. JNDI serialisation needs
to use StringRefAddr to support this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message