activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1489) Add TimedBuffer to Critical Analyzer
Date Tue, 31 Oct 2017 10:47:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226597#comment-16226597
] 

ASF GitHub Bot commented on ARTEMIS-1489:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1624
  
    @mtaylor Probably instead of using an instrinsic lock (aka `synchronize`) would be better
to use a `ReentrantLock` that has different utilities to check if a lock is acquired and could
avoid deadlocks/starvation using [tryLock](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantLock.html#tryLock(long,%20java.util.concurrent.TimeUnit)):
if it will wail with a specified timeout than a critical error could be called.


> Add TimedBuffer to Critical Analyzer
> ------------------------------------
>
>                 Key: ARTEMIS-1489
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1489
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>             Fix For: 2.4.0
>
>
> In certain scenarios the server may take longer to detect dead locks through the critical
analyzer.
> Say the timed buffer cannot sync. you won't be able to detect any deadlock unless you
have extra producers or extra IO happening through different threads.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message