activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1476) HdrHistogram support on verbose SyncCalculation
Date Mon, 23 Oct 2017 18:30:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215602#comment-16215602
] 

ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1605#discussion_r146353744
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
    @@ -69,74 +171,55 @@ public static long syncTest(File datafolder,
     
              file.close();
     
    -         long[] result = new long[tries];
    +         final long[] elapsedMillis = new long[tries];
     
    -         byte[] block = new byte[blockSize];
    -
    -         for (int i = 0; i < block.length; i++) {
    -            block[i] = (byte) 't';
    -         }
    -
    -         ByteBuffer bufferBlock = factory.newBuffer(blockSize);
    -         bufferBlock.put(block);
    -         bufferBlock.position(0);
    -
    -         final ReusableLatch latch = new ReusableLatch(0);
    -
    -         IOCallback callback = new IOCallback() {
    -            @Override
    -            public void done() {
    -               latch.countDown();
    -            }
    -
    -            @Override
    -            public void onError(int errorCode, String errorMessage) {
    -
    -            }
    -         };
    -
    -         DecimalFormat dcformat = new DecimalFormat("###.##");
    +         final DecimalFormat dcformat = new DecimalFormat("###.##");
              for (int ntry = 0; ntry < tries; ntry++) {
     
    +            //perform a gc on each test iteration to help cleanup of callbacks/garbage
    +            System.gc();
    --- End diff --
    
    I wouldn't do this. 
    
    The previous version was pretty much garbage free... if you must do this, I wouldn't merge
the commit at all.
    
    
    Besides... System.gc() will start a gc in parallel, and you will be already measuring
the next write iteration.. which will affect the performance.


> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
>                 Key: ARTEMIS-1476
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of [HdrHistogram|http://hdrhistogram.org/]
support to represent the write latencies percentile distribution while using it as a CLI command
(ie through the perf-journal command).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message