activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "guai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-6844) Misleading args order
Date Wed, 18 Oct 2017 13:11:00 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209298#comment-16209298
] 

guai commented on AMQ-6844:
---------------------------

lazy asses
If you hit something like that in someone else's code I bet you'll think "what an idiot wrote
this one, I will never do it"

> Misleading args order
> ---------------------
>
>                 Key: AMQ-6844
>                 URL: https://issues.apache.org/jira/browse/AMQ-6844
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JMS client
>    Affects Versions: 5.15.1
>            Reporter: guai
>
> org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory: 
> public ActiveMQConnectionFactory(String url, String user, String password) {...}
> org.apache.activemq.ActiveMQConnectionFactory:
> public ActiveMQConnectionFactory(String userName, String password, String brokerURL)
{...}
> all three are strings, url first vs url last can cause problems while migrating and compiler
won't even notice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message