activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1464) Core to AMQP conversion BytesMessage corrupts bytes
Date Tue, 17 Oct 2017 09:17:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207211#comment-16207211
] 

ASF GitHub Bot commented on ARTEMIS-1464:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1590#discussion_r145072050
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
---
    @@ -158,11 +162,29 @@ public void testBytesMessageSendReceive() throws Throwable {
        }
     
        @Test(timeout = 60000)
    -   public void testMessageSendReceive() throws Throwable {
    +   public void testBytesMessageSendReceiveFromAMQPToAMQP() throws Throwable {
    +      testBytesMessageSendReceive(createConnection(), createConnection());
    +   }
    +
    +   @Test(timeout = 60000)
    +   public void testBytesMessageSendReceiveFromCoreToAMQP() throws Throwable {
    +      testBytesMessageSendReceive(createCoreConnection(), createConnection());
    +   }
    +
    +   @Test(timeout = 60000)
    +   public void testBytesMessageSendReceiveFromCoreToCore() throws Throwable {
    --- End diff --
    
    Its so we check cross compatibly to and from amqp. see other similar test cases, the core
to core ones are just completeness on the combinations.


> Core to AMQP conversion BytesMessage corrupts bytes
> ---------------------------------------------------
>
>                 Key: ARTEMIS-1464
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1464
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0, 2.3.0
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>             Fix For: 2.4.0
>
>
> When sending a Core JMS BytesMessage and consuming via AMQP , the byte array is corrupted,
the sent byte[] != received byte[]
> byte length is not equal, it seems the bodybuffer length is not honoured during the conversion
(which caters for buffer headers and other offsets)
> Also noted is that when AMQP producer the body is of AMQP type "Data" where as when using
Core producer and the broker translates to AMQP the body becomes AMQP type "AmqpValue", this
also seems like a miss-behaviour and possibly linked to the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message