activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1447) JDBC NodeManager to support JDBC HA Shared Store
Date Fri, 27 Oct 2017 23:41:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223056#comment-16223056
] 

ASF GitHub Bot commented on ARTEMIS-1447:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1620#discussion_r147536740
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
    @@ -31,7 +34,27 @@
     
        private volatile long timeoutNanoSeconds;
     
    -   private volatile long checkTimeNanoSeconds;
    +   // one minute by default.. the server will change it for sure
    +   private volatile long checkTimeNanoSeconds = TimeUnit.SECONDS.toNanos(60);
    +
    +   private final ActiveMQScheduledComponent scheduledComponent;
    +
    +   private final AtomicBoolean running = new AtomicBoolean(false);
    +
    +   public CriticalAnalyzerImpl() {
    +      // this will make the scheduled component to start its own pool
    +      this(null, null);
    +   }
    +
    +   public CriticalAnalyzerImpl(ScheduledExecutorService scheduledExecutorService, Executor
executor) {
    --- End diff --
    
    Should this then become private? To avoid people using it withou the null's?


> JDBC NodeManager to support JDBC HA Shared Store
> ------------------------------------------------
>
>                 Key: ARTEMIS-1447
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1447
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>             Fix For: 2.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message