activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Bish (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ARTEMIS-1395) FindBugs: Dubious method used: System.exit() in CoreMessage#toString()
Date Sat, 09 Sep 2017 18:56:01 GMT

     [ https://issues.apache.org/jira/browse/ARTEMIS-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Timothy Bish resolved ARTEMIS-1395.
-----------------------------------
       Resolution: Fixed
         Assignee: Timothy Bish
    Fix Version/s: 2.4.0

> FindBugs: Dubious method used: System.exit() in CoreMessage#toString()
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1395
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1395
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>         Environment: commit 53a9c9b47b8c64ff2c0f2c6be40a1cf5984e5e8b (HEAD -> master,
upstream/master)
> Merge: 49ef04b6f d2dcf1bba
> Author: Clebert Suconic <clebertsuconic@apache.org>
> Date:   Wed Sep 6 10:30:13 2017 -0400
>     This closes #1513
>            Reporter: Jiri Danek
>            Assignee: Timothy Bish
>            Priority: Trivial
>             Fix For: 2.4.0
>
>
> This is weird. Possibly some left over debugging code. I never saw this actually crash
Artemis, though. Still, I think it should be changed.
> {code}
> 1079   @Override
> 1080   public String toString() {
> 1081      try {
> 1082         checkProperties();
> 1083         return "CoreMessage[messageID=" + messageID + ",durable=" + isDurable()
+ ",userID=" + getUserID() + ",priority=" + this.getPriority()  +
> 1084            ", timestamp=" + toDate(getTimestamp()) + ",expiration=" + toDate(getExpiration())
+
> 1085            ", durable=" + durable + ", address=" + getAddress() + ",properties="
+ properties + "]@" + System.identityHashCode(this);
> 1086      } catch (Throwable e) {
> 1087         e.printStackTrace();
>     	
> CID 1455427 (#1 of 1): Dm: Dubious method used (FB.DM_EXIT)
> 1. defect: org.apache.activemq.artemis.core.message.impl.CoreMessage.toString() invokes
System.exit(...), which shuts down the entire virtual machine.
> 1088         System.exit(-1);
> 1089         return "ServerMessage[messageID=" + messageID + "]";
> 1090      }
> 1091   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message