activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1393) CriticalAnalyzer timeout uses System::currentTimeMillis
Date Thu, 07 Sep 2017 12:51:01 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156908#comment-16156908
] 

ASF GitHub Bot commented on ARTEMIS-1393:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1515#discussion_r137529106
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalMeasure.java
---
    @@ -17,36 +17,48 @@
     
     package org.apache.activemq.artemis.utils.critical;
     
    -import org.jboss.logging.Logger;
    +import java.util.concurrent.atomic.AtomicLongFieldUpdater;
     
     public class CriticalMeasure {
     
    -   private static final Logger logger = Logger.getLogger(CriticalMeasure.class);
    +   //uses updaters to avoid creates many AtomicLong instances
    +   private static final AtomicLongFieldUpdater<CriticalMeasure> TIME_ENTER_UPDATER
= AtomicLongFieldUpdater.newUpdater(CriticalMeasure.class, "timeEnter");
    +   private static final AtomicLongFieldUpdater<CriticalMeasure> TIME_LEFT_UPDATER
= AtomicLongFieldUpdater.newUpdater(CriticalMeasure.class, "timeLeft");
     
        private volatile long timeEnter;
    --- End diff --
    
    this one: https://github.com/apache/activemq-artemis/pull/1518
    I wasn't aware about this behaviour of System::nanoTime: having received a good review
has helped me to dig into it and find it :+1: 


> CriticalAnalyzer timeout uses System::currentTimeMillis
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1393
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1393
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> To compute timeouts of the CriticalAnalyzer Instead of System::currentTimeMillis is preferrable
to use System::nanoTime, that is not sensible to OS changes on the system clock (eg NTP compensation).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message