activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1393) CriticalAnalyzer timeout uses System::currentTimeMillis
Date Thu, 07 Sep 2017 06:45:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156568#comment-16156568
] 

ASF GitHub Bot commented on ARTEMIS-1393:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1515#discussion_r137457338
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalMeasure.java
---
    @@ -17,28 +17,39 @@
     
     package org.apache.activemq.artemis.utils.critical;
     
    -import org.jboss.logging.Logger;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.atomic.AtomicLongFieldUpdater;
     
    -public class CriticalMeasure {
    +final class CriticalMeasure {
    --- End diff --
    
    It is a good point for sure, but I agree only on the second half: is out of scope for
the change so I can push a different PR just with it (and for the atomic changes too I can
say).
    For the first half I do not agree: is not a personal taste, but the explicit declaration
of the original intent. That class wasn't designed to be extended or used in other points
in the code.


> CriticalAnalyzer timeout uses System::currentTimeMillis
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1393
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1393
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> To compute timeouts of the CriticalAnalyzer Instead of System::currentTimeMillis is preferrable
to use System::nanoTime, that is not sensible to OS changes on the system clock (eg NTP compensation).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message