activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1393) CriticalAnalyzer timeout uses System::currentTimeMillis
Date Wed, 06 Sep 2017 16:12:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155597#comment-16155597
] 

ASF GitHub Bot commented on ARTEMIS-1393:
-----------------------------------------

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1515

    ARTEMIS-1393 CriticalAnalyzer timeout uses System::currentTimeMillis

    The timeout logic is changed to use System::nanoTime, less sensible to OS clock changes.
    The volatile set on CriticalMeasure are changed with cheaper lazySet.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis critical_analyzer_nano_timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1515
    
----
commit c47b7a45ad02791582da3cec4271e60ba215bf3e
Author: Francesco Nigro <nigro.fra@gmail.com>
Date:   2017-09-06T16:08:42Z

    ARTEMIS-1393 CriticalAnalyzer timeout uses System::currentTimeMillis
    
    The timeout logic is changed to use System::nanoTime, less sensible to OS clock changes.
    The volatile set on CriticalMeasure are changed with cheaper lazySet.

----


> CriticalAnalyzer timeout uses System::currentTimeMillis
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1393
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1393
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> To compute timeouts of the CriticalAnalyzer Instead of System::currentTimeMillis is preferrable
to use System::nanoTime, that is not sensible to OS changes on the system clock (eg NTP compensation).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message