Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3B764166765 for ; Tue, 22 Aug 2017 10:16:09 +0200 (CEST) Received: (qmail 81023 invoked by uid 500); 22 Aug 2017 08:16:08 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 81014 invoked by uid 99); 22 Aug 2017 08:16:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 08:16:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A4582C2C30 for ; Tue, 22 Aug 2017 08:16:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.952 X-Spam-Level: X-Spam-Status: No, score=-98.952 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E_AraVk3tTn3 for ; Tue, 22 Aug 2017 08:16:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6758A5FE66 for ; Tue, 22 Aug 2017 08:16:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F0BAEE0D57 for ; Tue, 22 Aug 2017 08:16:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 629F625381 for ; Tue, 22 Aug 2017 08:16:01 +0000 (UTC) Date: Tue, 22 Aug 2017 08:16:01 +0000 (UTC) From: "Markus Gerstel (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMQ-6796) Acknowledging messages out of order in a STOMP 1.1 transaction raises exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMQ-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Gerstel updated AMQ-6796: -------------------------------- Description: Reproducing the problem: * Receive two messages via STOMP on a subscription with ack:client-individual * Start a transaction * Acknowledge message #2 * Acknowledge message #1 * Commit the transaction I have prepared a [unit test|https://github.com/Anthchirp/activemq/commit/7df4f25975c6500e65b1688ca81e761c1825a32a] for this ([patch file|https://github.com/Anthchirp/activemq/commit/7df4f25975c6500e65b1688ca81e761c1825a32a.patch]) Expected behaviour: * Both messages are acknowledged, life goes on Observed behaviour: * Exception is raised {{javax.jms.JMSException: Unmatched acknowledge: MessageAck {commandId = 0, responseRequired = false, ackType = 2, consumerId = ID:(...)-6:555:-1:1, firstMessageId = null, lastMessageId = ID:(...)-6:555:-1:1:1, destination = queue://(...), transactionId = null, messageCount = 2, poisonCause = null}; Expected message count (2) differs from count in dispatched-list (1) at org.apache.activemq.broker.region.PrefetchSubscription.assertAckMatchesDispatched(PrefetchSubscription.java:519) at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:211) at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:528) at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:475) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:276) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:581) at org.apache.activemq.command.MessageAck.visit(MessageAck.java:245) at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:330) at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:194) at org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:45) at org.apache.activemq.transport.AbstractInactivityMonitor.onCommand(AbstractInactivityMonitor.java:301) at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:97) at org.apache.activemq.transport.stomp.StompSubscription.onStompCommit(StompSubscription.java:125) at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommit(ProtocolConverter.java:521) at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:256) at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85) at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83) at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:233) at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215) at java.lang.Thread.run(Thread.java:748)}} was: Reproducing the problem: * Receive two messages via STOMP on a subscription with ack:client-individual * Start a transaction * Acknowledge message #2 * Acknowledge message #1 * Commit the transaction I have prepared a [unit test|https://github.com/Anthchirp/activemq/commit/4d8394c621c1bc3785e552681e59e5d2f3525a89] for this ([patch file|https://github.com/Anthchirp/activemq/commit/4d8394c621c1bc3785e552681e59e5d2f3525a89.patch]) Expected behaviour: * Both messages are acknowledged, life goes on Observed behaviour: * Exception is raised {{javax.jms.JMSException: Unmatched acknowledge: MessageAck {commandId = 0, responseRequired = false, ackType = 2, consumerId = ID:(...)-6:555:-1:1, firstMessageId = null, lastMessageId = ID:(...)-6:555:-1:1:1, destination = queue://(...), transactionId = null, messageCount = 2, poisonCause = null}; Expected message count (2) differs from count in dispatched-list (1) at org.apache.activemq.broker.region.PrefetchSubscription.assertAckMatchesDispatched(PrefetchSubscription.java:519) at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:211) at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:528) at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:475) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:276) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:581) at org.apache.activemq.command.MessageAck.visit(MessageAck.java:245) at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:330) at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:194) at org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:45) at org.apache.activemq.transport.AbstractInactivityMonitor.onCommand(AbstractInactivityMonitor.java:301) at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:97) at org.apache.activemq.transport.stomp.StompSubscription.onStompCommit(StompSubscription.java:125) at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommit(ProtocolConverter.java:521) at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:256) at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85) at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83) at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:233) at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215) at java.lang.Thread.run(Thread.java:748)}} > Acknowledging messages out of order in a STOMP 1.1 transaction raises exception > ------------------------------------------------------------------------------- > > Key: AMQ-6796 > URL: https://issues.apache.org/jira/browse/AMQ-6796 > Project: ActiveMQ > Issue Type: Bug > Components: stomp > Affects Versions: 5.15.0 > Reporter: Markus Gerstel > > Reproducing the problem: > * Receive two messages via STOMP on a subscription with ack:client-individual > * Start a transaction > * Acknowledge message #2 > * Acknowledge message #1 > * Commit the transaction > I have prepared a [unit test|https://github.com/Anthchirp/activemq/commit/7df4f25975c6500e65b1688ca81e761c1825a32a] for this ([patch file|https://github.com/Anthchirp/activemq/commit/7df4f25975c6500e65b1688ca81e761c1825a32a.patch]) > Expected behaviour: > * Both messages are acknowledged, life goes on > Observed behaviour: > * Exception is raised > {{javax.jms.JMSException: Unmatched acknowledge: MessageAck {commandId = 0, responseRequired = false, ackType = 2, consumerId = ID:(...)-6:555:-1:1, firstMessageId = null, lastMessageId = ID:(...)-6:555:-1:1:1, destination = queue://(...), transactionId = null, messageCount = 2, poisonCause = null}; Expected message count (2) differs from count in dispatched-list (1) > at org.apache.activemq.broker.region.PrefetchSubscription.assertAckMatchesDispatched(PrefetchSubscription.java:519) > at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:211) > at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:528) > at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:475) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:276) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:89) > at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:581) > at org.apache.activemq.command.MessageAck.visit(MessageAck.java:245) > at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:330) > at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:194) > at org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:45) > at org.apache.activemq.transport.AbstractInactivityMonitor.onCommand(AbstractInactivityMonitor.java:301) > at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:97) > at org.apache.activemq.transport.stomp.StompSubscription.onStompCommit(StompSubscription.java:125) > at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommit(ProtocolConverter.java:521) > at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:256) > at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85) > at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83) > at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:233) > at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215) > at java.lang.Thread.run(Thread.java:748)}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)