activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1359) AMQP: Broker reencodes the message Header needlessly on outbound dispatch
Date Mon, 21 Aug 2017 21:39:03 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135876#comment-16135876
] 

ASF GitHub Bot commented on ARTEMIS-1359:
-----------------------------------------

GitHub user tabish121 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1481

    ARTEMIS-1359 Skip re-encode Headers on messages if not needed

    Only reencode the Header on a Message when the redelivering the Message
    to avoid overhead and unneeded modification to the original encoding of
    the Header.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1359

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1481
    
----
commit e4e5d686315d7dc2a4620a1eeb4fe3d3acef0e5a
Author: Timothy Bish <tabish121@gmail.com>
Date:   2017-08-21T21:35:51Z

    ARTEMIS-1359 Skip re-encode Headers on messages if not needed
    
    Only reencode the Header on a Message when the redelivering the Message
    to avoid overhead and unneeded modification to the original encoding of
    the Header.

----


> AMQP: Broker reencodes the message Header needlessly on outbound dispatch
> -------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1359
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1359
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.2.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>             Fix For: 2.3.0
>
>
> On most dispatches of an AMQP message the logic in AMQPMessage results in the AMQP Header
being encoded instead of using the existing AMQP Header that arrived with the message.  This
encoding results in messages that have different header encodings than the original sent message
(although still with logically equivalent values) and impacts performance of message dispatching.
 
> The broker should only be re-encoding the Header when updating the delivery count on
redelivered messages.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message