activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1354) AIOSequentialFile does not call IOError on write failure
Date Thu, 17 Aug 2017 14:08:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130445#comment-16130445
] 

ASF GitHub Bot commented on ARTEMIS-1354:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1468#discussion_r133722903
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
---
    @@ -304,7 +304,7 @@ public void run() {
              try {
                 libaioFile.write(position, bytes, buffer, this);
              } catch (IOException e) {
    -            callback.onError(-1, e.getMessage());
    --- End diff --
    
    hmmm.. nice catch...
    
    I though other things would catch the failures..
    
    
    The proper fix should been:
    
    ```
                callback.onError(-1, errorMessage);
                onIOError(e, "Failed to write to file", sequentialFile);
    ```


> AIOSequentialFile does not call IOError on write failure
> --------------------------------------------------------
>
>                 Key: ARTEMIS-1354
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1354
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>
> This has potential to cause loss of availability, particular in a HA environment as the
broker will not shut down when writes are failing due to disk or network failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message