activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1350) Update management console to expose client side objects
Date Fri, 18 Aug 2017 12:37:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132124#comment-16132124
] 

ASF GitHub Bot commented on ARTEMIS-1350:
-----------------------------------------

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1471#discussion_r133948157
  
    --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
    @@ -44,9 +44,30 @@
                         </button>
                     </form>
                 </div>
    +
    +            <div class="pull-right">
    +              <form class="form-inline">
    +                <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length
== 0"
    +                        ng-click="deleteDialog = true"
    +                        title="Close the selected Consumer">
    +                  <i class="icon-remove"></i> Close
    +                </button>
    +                &nbsp;&nbsp;&nbsp;
    +              </form>
    +            </div>
             </div>
         </div>
     
    +    <div hawtio-confirm-dialog="deleteDialog"
    +          ok-button-text="Close"
    +          on-ok="closeConsumer()">
    +       <div class="dialog-body">
    +         <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
    --- End diff --
    
    There are some issues with the layout.  The buttons do not disable when nothing select
and the submission will try with empty id.  I will see if I can fix here, @andytaylor I'll
send a PR to your branch.


> Update management console to expose client side objects
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1350
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1350
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Martyn Taylor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message