Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE464200CE5 for ; Sat, 8 Jul 2017 04:12:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ECD8516A70F; Sat, 8 Jul 2017 02:12:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3DEA116A70E for ; Sat, 8 Jul 2017 04:12:09 +0200 (CEST) Received: (qmail 88458 invoked by uid 500); 8 Jul 2017 02:12:06 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 88447 invoked by uid 99); 8 Jul 2017 02:12:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 02:12:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2DCAE191744 for ; Sat, 8 Jul 2017 02:12:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PmpqskAgISNR for ; Sat, 8 Jul 2017 02:12:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B48475FE54 for ; Sat, 8 Jul 2017 02:12:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2C38E07CF for ; Sat, 8 Jul 2017 02:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D132124694 for ; Sat, 8 Jul 2017 02:12:00 +0000 (UTC) Date: Sat, 8 Jul 2017 02:12:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1272) Artemis incorrectly handle MQTT acknowledgement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 08 Jul 2017 02:12:10 -0000 [ https://issues.apache.org/jira/browse/ARTEMIS-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078906#comment-16078906 ] ASF GitHub Bot commented on ARTEMIS-1272: ----------------------------------------- Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1389 This fix lacks any tests so it is not verifiable and would not be protected into the future > Artemis incorrectly handle MQTT acknowledgement > ----------------------------------------------- > > Key: ARTEMIS-1272 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1272 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: MQTT > Affects Versions: 1.5.3, 2.1.0 > Reporter: Odyldzhon Toshbekov > > When MQTT client send acknowledgement Artemis acknowledge previous sent messages. > Test case: > 1. Connect to Broker (client 1) > 2. Connect to Broker (client 2) > 2. Send two messages with QOS = 1 > 3. Send acknowledgement for second message > A.R. Artemis will remove from queue first and second message > E.R. Artemis should remove only second message > 4. Send acknowledgement for first message > A.R. WARN message "attempted to Ack already Ack'd message" > The cause of the problem located in the class MQTTPublisherManager methods "handlePubRec", "handlePubComp", "handlePubAck" and "sendMessage" > Fix: replace "session.getServerSession().acknowledge" to session.getServerSession().individualAcknowledge -- This message was sent by Atlassian JIRA (v6.4.14#64029)