activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1276) [openwire-tests] Enable more OpenWire tests (from ActiveMQ 5)
Date Wed, 19 Jul 2017 05:24:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092594#comment-16092594
] 

ASF GitHub Bot commented on ARTEMIS-1276:
-----------------------------------------

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1409#discussion_r128155276
  
    --- Diff: tests/activemq5-unit-tests/pom.xml ---
    @@ -460,6 +460,8 @@
                       <exclude>**/org/apache/activemq/ProducerFlowControlTest.java</exclude>
                       <!-- exclude tests that are on client side only -->
                       <exclude>**/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java</exclude>
    +                  <!-- exclude tests for features not implemented in Artemis -->
    +                  <exclude>**/org/apache/activemq/MessageEvictionTest.java</exclude>
    --- End diff --
    
    if that is how it is done regarding non-applicable activemq5 tests in Artemis, then sure,
I can just delete the test.


> [openwire-tests] Enable more OpenWire tests (from ActiveMQ 5)
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-1276
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1276
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: OpenWire
>    Affects Versions: 2.2.0
>            Reporter: Jiri Danek
>            Priority: Minor
>
> I've been looking into the currently disabled OpenWire tests, if there is a way to implement
support for more of them and enable them.
> I believe I've made some progress on this front, so I'd wish to discuss
> 1) what is the endgame about these tests; do we want to eventually run them all, or is
it expected to to ignore some?
> 2) what tests would be useful to enable now? I've been looking at them from the point
of how easy it is to enable them, not how useful it is.
> 3) would it be ok to add mockito as a test dependency? it seems useful, because sometimes
it is necessary to wrap something in ActiveMQ5 class, and doing a proxy avoids having to invoke
superclass constructors (when the thing that needs to be implemented is a class and not an
interface). Mockito is IMO nicer to use than using java.lang.reflect.Proxy.newProxyInstance
directly.
> and propose PR based on that discussion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message