activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1272) Artemis incorrectly handle MQTT acknowledgement
Date Fri, 07 Jul 2017 23:44:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078843#comment-16078843
] 

ASF GitHub Bot commented on ARTEMIS-1272:
-----------------------------------------

GitHub user Odyldzhon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1389

    ARTEMIS-1272 Artemis incorrectly handle MQTT acknowledgement

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Odyldzhon/activemq-artemis ARTEMIS-1272_MQTT_acknowledgement_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1389
    
----
commit 021fd9a8e03a563eceb0c7bed1aa52f85696f973
Author: Odyldzhon Toshbekov <odyldzhon.toshbekov@ampard.com>
Date:   2017-07-07T23:41:41Z

    fix mqtt acknowledgement issue

----


> Artemis incorrectly handle MQTT acknowledgement
> -----------------------------------------------
>
>                 Key: ARTEMIS-1272
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1272
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: MQTT
>    Affects Versions: 1.5.3, 2.1.0
>            Reporter: Odyldzhon Toshbekov
>
> When MQTT client send acknowledgement Artemis acknowledge previous sent messages.
> Test case:
> 1. Connect to Broker (client 1)
> 2. Connect to Broker (client 2)
> 2. Send two messages with QOS = 1
> 3. Send acknowledgement for second message
> A.R. Artemis will remove from queue first and second message
> E.R. Artemis should remove only second message
> 4. Send acknowledgement for first message
> A.R. WARN message "attempted to Ack already Ack'd message"
> The cause of the problem located in the class MQTTPublisherManager methods "handlePubRec",
"handlePubComp", "handlePubAck" and "sendMessage"
> Fix: replace "session.getServerSession().acknowledge" to session.getServerSession().individualAcknowledge




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message