activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1266) Mapped Journal refactoring
Date Sat, 01 Jul 2017 00:35:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070900#comment-16070900
] 

ASF GitHub Bot commented on ARTEMIS-1266:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1381#discussion_r125150037
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedByteBufferCache.java
---
    @@ -1,224 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements. See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License. You may obtain a copy of the License at
    - *
    - *     http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -package org.apache.activemq.artemis.core.io.mapped;
    -
    -import java.io.File;
    -import java.io.FileNotFoundException;
    -import java.io.IOException;
    -import java.io.RandomAccessFile;
    -import java.lang.ref.WeakReference;
    -import java.nio.ByteOrder;
    -import java.nio.MappedByteBuffer;
    -import java.nio.channels.FileChannel;
    -import java.nio.channels.FileLock;
    -import java.util.ArrayList;
    -
    -import io.netty.util.internal.PlatformDependent;
    -
    -final class MappedByteBufferCache implements AutoCloseable {
    --- End diff --
    
    Simplification is great!!!!! 


> Mapped Journal refactoring
> --------------------------
>
>                 Key: ARTEMIS-1266
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1266
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> The MAPPED journal refactoring include:
> - simplified lifecycle and logic (eg fixed file size with single mmap memory region)
> - supports for the TimedBuffer to coalesce msyncs (via Decorator pattern)
> - TLAB pooling of direct ByteBuffer like the NIO journal
> - remove of old benchmarks and benchmark dependencies



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message