Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Wed, 21 Jun 2017 11:31:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13081373.1498038448000.68771.1498044660070@Atlassian.JIRA>
In-Reply-To: <JIRA.13081373.1498038448000@Atlassian.JIRA>
References: <JIRA.13081373.1498038448000@Atlassian.JIRA> <JIRA.13081373.1498038448927@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARTEMIS-1244) [mqtt] Retain flag of received
 message is lost (caught by outgoing interceptor)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 21 Jun 2017 11:31:06 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-1244?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
057348#comment-16057348 ]=20

ASF GitHub Bot commented on ARTEMIS-1244:
-----------------------------------------

GitHub user michalxo opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1357

    Artemis 607 qe

    Please note, that testCheckInterceptedMQTTMessageProperties currently f=
ails because of issue     ARTEMIS-1244 [mqtt] Retain flag of received messa=
ge is lost (caught by outgoing interceptor)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michalxo/activemq-artemis artemis-607-qe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1357
   =20
----
commit 90359ea3dceb6da73eb816a747c6c087e2125f57
Author: Michal T=C3=B3th <mtoth@redhat.com>
Date:   2017-06-21T09:37:45Z

    ARTEMIS-607 New tests AMQP,MQTT,Stomp interceptor properties tests
   =20
    Added tests for AMQP, MQTT and Stomp protocol for interceptors.
    Tests are checking intercepted message properties.
    Linked issue ARTEMIS-607

commit 8c00c752b1b5f11546e52701bfbcbc52439e83ec
Author: Michal T=C3=B3th <mtoth@redhat.com>
Date:   2017-06-21T11:17:54Z

    ARTEMIS-1244 Retain flag code todo comment
   =20
    Identified possible bug in MQTT receive of missing retained flag.

----


> [mqtt] Retain flag of received message is lost (caught by outgoing interc=
eptor)
> -------------------------------------------------------------------------=
------
>
>                 Key: ARTEMIS-1244
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1244
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: MQTT
>    Affects Versions: 2.1.0
>            Reporter: Michal Toth
>            Priority: Minor
>
> Upstream test: testCheckInterceptedMQTTMessageProperties] [https://github=
.com/michalxo/activemq-artemis/commit/119e90c6c5bd2ae523e01368544ae3cb66987=
c4a#diff-d2a66663368a8238bae6dc85ccbd5a5d|org/apache/activemq/artemis/tests=
/integration/interceptors/MQTTInterceptorPropertiesTest.java
> Asked for PR.
> While implementing an upstream test and checking MQTT Outgoing intercepto=
r, I have noticed that retain flag set to true is being lost when sending m=
essage out.
> However I did not manage to get information about this specific in [3.3.1=
.3. Retain|http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.ht=
ml#_Toc398718038].
> On the other hand I have found a sentence in [HiveMQ|http://www.hivemq.co=
m/blog/mqtt-essentials-part-8-retained-messages] part 8 article:
> {quote}
> Also the subscribing client can identify if a received message was a reta=
ined message or not, because the broker sends out retained messages with th=
e retained flag still set to true.
> {quote}
> So after all this might be a matter of implementation. (feature enhanceme=
nt or rejected bug)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)