Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C863C200CA8 for ; Thu, 15 Jun 2017 20:00:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C712D160BED; Thu, 15 Jun 2017 18:00:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19067160BC9 for ; Thu, 15 Jun 2017 20:00:08 +0200 (CEST) Received: (qmail 20964 invoked by uid 500); 15 Jun 2017 18:00:07 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 20830 invoked by uid 99); 15 Jun 2017 18:00:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 18:00:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4AE00C089A for ; Thu, 15 Jun 2017 18:00:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.952 X-Spam-Level: X-Spam-Status: No, score=-98.952 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id L3neBtfmvGxk for ; Thu, 15 Jun 2017 18:00:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 308235FCA4 for ; Thu, 15 Jun 2017 18:00:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 35116E00A3 for ; Thu, 15 Jun 2017 18:00:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5210921E12 for ; Thu, 15 Jun 2017 18:00:02 +0000 (UTC) Date: Thu, 15 Jun 2017 18:00:02 +0000 (UTC) From: "Justin Bertram (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ARTEMIS-1229) [extra-tests] JMSPagingFileDeleteTest#testTopicsWithNonDurableSubscription fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 15 Jun 2017 18:00:10 -0000 [ https://issues.apache.org/jira/browse/ARTEMIS-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050870#comment-16050870 ] Justin Bertram commented on ARTEMIS-1229: ----------------------------------------- The issue here is that when the connection is closed and the non-durable subscription queue is cleaned up {{QueueImpl#deleteQueue(boolean)}} invokes {{PostOffice#removeBinding}} which now will invoke {{PagingManager#deletePageStore}} since there are no more bindings on the address. Before the address changes there would still be a "fake" binding on the address to indicate it was a JMS topic. The {{deletePageStore}} method will "stop" the {{PagingStore}}. After {{deletePageStore}} is invoked then {{deleteQueue}} will eventually invoke {{.QueueImpl#destroyPaging}} which will itself eventually result in a call to {{PageCursorProviderImpl#cleanup}}. However, {{cleanup}} won't actually do anything because the {{PagingStore}} is stopped. Hence the test fails. I'm looking at a way to resolve the issue now. > [extra-tests] JMSPagingFileDeleteTest#testTopicsWithNonDurableSubscription fails > -------------------------------------------------------------------------------- > > Key: ARTEMIS-1229 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1229 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Affects Versions: 2.2.0 > Reporter: Jiri Danek > > The final assert in the test is currently failing (the address never stops paging) > According to git-blame, the failure appears since > {noformat} > 84e8a87325a976c9970b8e85d03fc33207623af3 is the first bad commit > commit 84e8a87325a976c9970b8e85d03fc33207623af3 > Author: jbertram > Date: Fri Oct 21 19:58:01 2016 -0500 > ARTEMIS-876 Remove all reliances on JMS prefixing > :040000 040000 4f20a20a99d56d90c0093351ba2ccb683372dc7c d8b859046c7909ee3061d4036fd79bf902f02dab M artemis-cli > :040000 040000 3ef1fe21e9e4a0677b4aee154293ad05c0570413 43814754470946f85415ffe9ff025a438fdc95e4 M artemis-core-client > :040000 040000 f29db0297262ba22155bc2d2a4c785586e7703e8 437d430a61d42a884a7dd4e670a08461b95a9387 M artemis-jms-client > :040000 040000 7103a3489948f3a96b5c09f087c2b23e91a1136d 4a2a55818a2f6813e2a0a1843c26a45769a81bd8 M artemis-jms-server > :040000 040000 8b08ed6083e29ab30e087cf546468f48fcfd44a1 970dbaf8f8c25a29bb6d8ef3af71dc9dd2065bfe M artemis-junit > :040000 040000 8e333c149a9a42ebb7a434dcb266fc0089566786 ae7fd47ff0588c4164d693fb196c7b2dceb4909e M artemis-protocols > :040000 040000 bd66869298686ced8435328eb8be75711596b103 3310cb3c6f9bec209eb1a26aca36eeec0f728298 M artemis-rest > :040000 040000 08bfa6e2197257d7cef5eda12b0759775912c13e d54b574c29d47d8b68ab25deaa49263802eb6b87 M artemis-server > :040000 040000 71b58c21d20d982cf9c84f1f96dcb8fdcb524477 a93c90dfbdf7b03f932251a0974084646d64411e M examples > :100644 100644 30c96cd1e8ee2c40bc4711b5cf2043550b9ceada d1e2552d3549ad14afa38f517138303b40b8b829 M pom.xml > :040000 040000 4c733114a1d9bc044fe1d34cda1d3abb1b6bf9e8 8e8dea6f3b5c4d6eb420f02a2cd19a3510126bae M tests > {noformat} > The commit attempts to fix tests too, maybe this one was missed. I do not know what the cause is, but I think it is different from ARTEMIS-1219. CC [~jbertram] -- This message was sent by Atlassian JIRA (v6.4.14#64029)