activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1247) Allow to enable replicated journal (not only at compilation time)
Date Thu, 22 Jun 2017 10:00:00 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059085#comment-16059085
] 

ASF GitHub Bot commented on ARTEMIS-1247:
-----------------------------------------

GitHub user rpelisse opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1360

    ARTEMIS-1247 - Allow to enable replicated journal (not only at compilation time)

    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1247
    Upstream Issue (Widfly): https://issues.jboss.org/browse/WFLY-8983
    Upstream Issue (EAP): https://issues.jboss.org/browse/JBEAP-11622
    
    I've added a system property 'artemis.trace.enabled' that can be pass to 'turn on' the
replicated journal. It seems to me the easiest and simple way of implement this, however feel
free to disagree :) and point me to a better approach !

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rpelisse/activemq-artemis ARTEMIS-1247

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1360
    
----

----


> Allow to enable replicated journal (not only at compilation time)
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-1247
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1247
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.1.0
>            Reporter: Romain PELISSE
>            Priority: Minor
>
> There is disabled logging of {{ReplicatedJournal}} due to hardcoded value:
> {code}
> private static final boolean trace = false;
> {code}
> Every trace log can never be logged:
> {code}
> if (ReplicatedJournal.trace) {
>          ReplicatedJournal.trace("Append record id = " + id + " recordType = " + recordType);
>       }
> {code}
> This is not ideal for investivatigation purposes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message