activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMQ-6699) STOMP headers are not escaped when using WebSocket
Date Wed, 14 Jun 2017 19:16:02 GMT

    [ https://issues.apache.org/jira/browse/AMQ-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049549#comment-16049549
] 

ASF subversion and git services commented on AMQ-6699:
------------------------------------------------------

Commit 2490c85fc5cc27cb32f01553784ef6bc63cd15f0 in activemq's branch refs/heads/master from
[~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=2490c85 ]

AMQ-6699 Fix STOMP over WS not encoding header values

When sending STOMP frames out over WS the marshal isn't doing a proper
encode based on the STOMP version in use and so header values can be
transmitted without proper escaping.  

> STOMP headers are not escaped when using WebSocket
> --------------------------------------------------
>
>                 Key: AMQ-6699
>                 URL: https://issues.apache.org/jira/browse/AMQ-6699
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: stomp
>    Affects Versions: 5.14.6
>         Environment: Java SE Runtime Environment (build 1.8.0_102-b14)
>            Reporter: Albertas Vyšniauskas
>            Priority: Minor
>         Attachments: stomp-over-websocket-escape-2.patch, stomp-over-websocket-escape.patch
>
>
> When using STOMP over WebSockets, STOMP header values are not escaped in frames sent
by ActiveMQ.
> When the following frame is sent:
> {quote}
> SEND
> destination:/queue/test
> escaped-header:one\ntwo\cthree
> Hello World
> {quote}
> ActiveMQ interprets escaped headers correctly, but does not escape them when sending
own frames:
> {quote}
> MESSAGE
> expires:0
> destination:/queue/test
> subscription:12345
> priority:4
> escaped-header:one
> two:three
> message-id:ID:-50091-1497003246573-3:1:-1:1:1
> timestamp:1497003247783
> Hello World
> {quote}
> Correctly escaped frame should look like this:
> {quote}
> MESSAGE
> expires:0
> destination:/queue/test
> subscription:12345
> priority:4
> escaped-header:one\ntwo\cthree
> message-id:ID\c-50091-1497003246573-3\c1\c-1\c1\c1
> timestamp:1497003247783
> Hello World
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message