Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Sat, 13 May 2017 07:28:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13071740.1494660045000.203304.1494660484137@Atlassian.JIRA>
In-Reply-To: <JIRA.13071740.1494660045000@Atlassian.JIRA>
References: <JIRA.13071740.1494660045000@Atlassian.JIRA> <JIRA.13071740.1494660045066@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and
 old Fixed TimedBuffer configurable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 13 May 2017 07:28:09 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009194#comment-16009194 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1268

    ARTEMIS-1162: Make new TimedBuffer Configurable

    Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable.
    
    Rename new version of TimedBuffer to AdaptingTimedBuffer (and tests)
    Add back old version of TimedBuffer to FixedTimedBuffer (and tests)
    Extract shared public interface
    Add configuration option to toggle between which TimedBuffer to user, in broker.xml "journal-timed-buffer-type=[FIXED,ADAPTING]"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1162

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1268
    
----
commit cd7ca0a16bba97f87e422869f1818a6e86396189
Author: Michael Andre Pearce <michael.andre.pearce@me.com>
Date:   2017-05-13T07:25:39Z

    ARTEMIS-1162: Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
    
    Rename new version of TimedBuffer to AdaptingTimedBuffer (and tests)
    Add back old version of TimedBuffer to FixedTimedBuffer (and tests)
    Extract shared public interface
    Add configuration option to toggle between which TimedBuffer to user, in broker.xml "journal-timed-buffer-type=[FIXED,ADAPTING]"

----


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> --------------------------------------------------------------------
>
>                 Key: ARTEMIS-1162
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Michael Andre Pearce
>             Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. This could cause behaviour/performance change of journal IO (and hopefully for the better).
> As this hasn't been run significantly in a real world production environment, to avoid causing any production deployment issues having unexpected behaviour changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it configurable to the new improved timed buffer. 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)