activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade
Date Tue, 30 May 2017 16:28:04 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029673#comment-16029673
] 

ASF GitHub Bot commented on ARTEMIS-1189:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1304

    ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade

    After upgrade of checkstyle, resolve violations
    remove checkstyle override added as temp measure at point of upgrade forced by sevntu

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis artemis-1189

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1304
    
----
commit d797a28711bd2aa076bb780d0a202d5e60b07952
Author: Michael Andre Pearce <michael.andre.pearce@me.com>
Date:   2017-05-29T22:48:50Z

    ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade
    
    After upgrade of checkstyle, resolve violations
    remove checkstyle override added as temp measure at point of upgrade forced by sevntu

----


> Fix checkstyle violations post checkstyle  upgrade
> --------------------------------------------------
>
>                 Key: ARTEMIS-1189
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors that it
should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce future
pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message