activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
Date Thu, 20 Apr 2017 14:58:04 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976841#comment-15976841
] 

ASF GitHub Bot commented on ARTEMIS-1093:
-----------------------------------------

Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
---
    @@ -53,38 +56,61 @@
     import org.apache.qpid.proton.engine.Sender;
     import org.jgroups.util.UUID;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     /**
      * Test basic send and receive scenarios using only AMQP sender and receiver links.
      */
    +@RunWith(Parameterized.class)
    --- End diff --
    
    This seems like an unnecessary change to this test.  The intent here is to test basic
AMQP protocol support not to test the FQQN support in the broker which it appears is already
done in the ProtonFullQualifiedNameTest.  I'd prefer if we could keep tests targeted and not
try and make them test the entirety of the broker features in one monolithic test case as
that makes it harder to maintain.  If you changed this one why didn't you change every single
AMQP test in the same fashion?


> Full qualified queue name support
> ---------------------------------
>
>                 Key: ARTEMIS-1093
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1093
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.0.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 2.next
>
>
> Broker should support full qualified queue names (FQQN) as well as bare queue names.
This means when clients access to a queue they have two equivalent ways to do so. One way
is by queue names and the other is by FQQN (i.e. address::qname) names. When accessing a queue
by its bare name, it is required that the name should be unique across all addresses.
> Otherwise a warning is given and client should use FQQN instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message