Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Thu, 2 Mar 2017 06:43:45 +0000 (UTC)
From: "Miroslav Novak (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13047583.1488436967000.39500.1488437025210@Atlassian.JIRA>
In-Reply-To: <JIRA.13047583.1488436967000@Atlassian.JIRA>
References: <JIRA.13047583.1488436967000@Atlassian.JIRA> <JIRA.13047583.1488436967935@jira-lw-us.apache.org>
Subject: [jira] [Created] (ARTEMIS-1011) Slow consumer detection - producer
 msg/s rate for queue should take into account messages which are already in
 queue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Mar 2017 06:43:49 -0000

Miroslav Novak created ARTEMIS-1011:
---------------------------------------

             Summary: Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue
                 Key: ARTEMIS-1011
                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
             Project: ActiveMQ Artemis
          Issue Type: Bug
          Components: Broker
    Affects Versions: 1.5.3, 2.0.0
            Reporter: Miroslav Novak


There is still a problem how producer msg/s rate is calculated in {{QueueImpl.getRate()}} for slow consumer detection. It calculates only messages added during the last slow consumer check period. As this is used to figure out, in which msg/s rate the queue could serve the consumer then it should also take into account messages which are already in queue at the start of queueRateCheckTime period. 

Current implementation is problem for cases when messages are sent to queue in bursts, for example producer sends 1000s messages in a few seconds and then stops and will do that again in 1 hour. QueueImpl.getRate() method returns 0 msg/s for slow consumer check period set to for example 5 min and slow consumer detection will be skipped. 

I tried to fix it by following change to QueueImpl.getRate() method and seems to be ok, wdyt?
{code}
   private final AtomicLong messageCountSnapshot = new AtomicLong(0);
   public float getRate() {
      long locaMessageAdded = getMessagesAdded();
      float timeSlice = ((System.currentTimeMillis() - queueRateCheckTime.getAndSet(System.currentTimeMillis())) / 1000.0f);
      if (timeSlice == 0) {
         messagesAddedSnapshot.getAndSet(locaMessageAdded);
         return 0.0f;
      }
      return BigDecimal.valueOf(((locaMessageAdded - messagesAddedSnapshot.getAndSet(locaMessageAdded)) + messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2, BigDecimal.ROUND_UP).floatValue();
   }
{code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)