Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Tue, 14 Mar 2017 11:59:41 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13034391.1484234227000.13350.1489492781612@Atlassian.JIRA>
In-Reply-To: <JIRA.13034391.1484234227000@Atlassian.JIRA>
References: <JIRA.13034391.1484234227000@Atlassian.JIRA> <JIRA.13034391.1484234227479@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AMQ-6561) Broker does not close connection for
 all connection attempt errors
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Mar 2017 11:59:48 -0000


    [ https://issues.apache.org/jira/browse/AMQ-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924062#comment-15924062 ] 

ASF subversion and git services commented on AMQ-6561:
------------------------------------------------------

Commit 36689beff755fd6391c3a8291d1e89fc782eac0d in activemq's branch refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=36689be ]

[AMQ-6561] fix up unit test that expects socket to remain open after InvalidClientIDException, dubious expectation in the test that wants to verify broker is ok


> Broker does not close connection for all connection attempt errors
> ------------------------------------------------------------------
>
>                 Key: AMQ-6561
>                 URL: https://issues.apache.org/jira/browse/AMQ-6561
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.14.3
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>             Fix For: 5.15.0, 5.14.4
>
>
> When a client connects to the broker the connection gets added inside the processAddConnection method in TransportConnection.  Right now if there is an exception the socket is only shutdown if the type of exception is SecurityException.  However the connection should really be closed if any error occurs when trying to add the connection.  
> For example if an InvalidClientIDException occurs then the connection is no longer tracked by the broker but the socket stays open until the client actually closes it on their end. This should be fixed so that the error terminates the socket connection since the connection attempt failed.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)