Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3AA8F200C2F for ; Mon, 6 Mar 2017 13:57:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 39788160B81; Mon, 6 Mar 2017 12:57:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A01F160B73 for ; Mon, 6 Mar 2017 13:57:36 +0100 (CET) Received: (qmail 83692 invoked by uid 500); 6 Mar 2017 12:57:35 -0000 Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list issues@activemq.apache.org Received: (qmail 83683 invoked by uid 99); 6 Mar 2017 12:57:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Mar 2017 12:57:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3CC34C69D0 for ; Mon, 6 Mar 2017 12:57:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fide-PFr8Bxq for ; Mon, 6 Mar 2017 12:57:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0234C5F403 for ; Mon, 6 Mar 2017 12:57:34 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 42D43E05BB for ; Mon, 6 Mar 2017 12:57:33 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EA5232416E for ; Mon, 6 Mar 2017 12:57:32 +0000 (UTC) Date: Mon, 6 Mar 2017 12:57:32 +0000 (UTC) From: "Christopher L. Shannon (JIRA)" To: issues@activemq.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMQ-6377) Introduce a periodic disk sync mode for KahaDB journal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 06 Mar 2017 12:57:37 -0000 [ https://issues.apache.org/jira/browse/AMQ-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897226#comment-15897226 ] Christopher L. Shannon commented on AMQ-6377: --------------------------------------------- [~gtully], I went ahead and fixed this to just do the enum comparison so there is no more use of String in that getter. > Introduce a periodic disk sync mode for KahaDB journal > ------------------------------------------------------ > > Key: AMQ-6377 > URL: https://issues.apache.org/jira/browse/AMQ-6377 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB > Affects Versions: 5.13.4 > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Fix For: 5.14.0 > > > KahaDB has two modes for journal disk syncs, either always sync for each write or never sync. I'm proposing that we add a third option, a period disk sync. > The intended behavior of this would be to run a task in the file appender that would sync the file (if necessary) at some periodic interval (such as every 500 ms, or 1 second, etc) instead of every write. The file would also be synced on close (on file rollover or shutdown) > In my testing, syncing every 1 second has been proven to be nearly indistinguishable performance as never disk syncing but is a safer option as you insure that a sync is performed at least once per interval. -- This message was sent by Atlassian JIRA (v6.3.15#6346)