activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miroslav Novak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-1011) Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue
Date Wed, 08 Mar 2017 06:30:39 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900789#comment-15900789
] 

Miroslav Novak commented on ARTEMIS-1011:
-----------------------------------------

Agreed, thanks [~jbertram] for looking at it. My comment above was just that based on code
review of AbortSlowConsumerStrategy class from ActiveMQ 5.x, it seems that there is also this
issue. Artemis will be more robust in this.

> Slow consumer detection - producer msg/s rate for queue should take into account messages
which are already in queue
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1011
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.3
>            Reporter: Miroslav Novak
>             Fix For: 2.0.0, 1.5.5
>
>
> There is still a problem how producer msg/s rate is calculated in {{QueueImpl.getRate()}}
for slow consumer detection. It calculates only messages added during the last slow consumer
check period. As this is used to figure out, in which msg/s rate the queue could serve the
consumer then it should also take into account messages which are already in queue at the
start of queueRateCheckTime period. 
> Current implementation is problem for cases when messages are sent to queue in bursts,
for example producer sends 1000s messages in a few seconds and then stops and will do that
again in 1 hour. QueueImpl.getRate() method returns 0 msg/s for slow consumer check period
set to for example 5 min and slow consumer detection will be skipped. 
> I tried to fix it by following change to QueueImpl.getRate() method and seems to be ok,
wdyt?
> {code}
>    private final AtomicLong messageCountSnapshot = new AtomicLong(0);
>    public float getRate() {
>       long locaMessageAdded = getMessagesAdded();
>       float timeSlice = ((System.currentTimeMillis() - queueRateCheckTime.getAndSet(System.currentTimeMillis()))
/ 1000.0f);
>       if (timeSlice == 0) {
>          messagesAddedSnapshot.getAndSet(locaMessageAdded);
>          return 0.0f;
>       }
>       return BigDecimal.valueOf(((locaMessageAdded - messagesAddedSnapshot.getAndSet(locaMessageAdded))
+ messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2, BigDecimal.ROUND_UP).floatValue();
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message