activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miroslav Novak (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARTEMIS-1011) Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue
Date Thu, 02 Mar 2017 06:43:45 GMT
Miroslav Novak created ARTEMIS-1011:
---------------------------------------

             Summary: Slow consumer detection - producer msg/s rate for queue should take
into account messages which are already in queue
                 Key: ARTEMIS-1011
                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
             Project: ActiveMQ Artemis
          Issue Type: Bug
          Components: Broker
    Affects Versions: 1.5.3, 2.0.0
            Reporter: Miroslav Novak


There is still a problem how producer msg/s rate is calculated in {{QueueImpl.getRate()}}
for slow consumer detection. It calculates only messages added during the last slow consumer
check period. As this is used to figure out, in which msg/s rate the queue could serve the
consumer then it should also take into account messages which are already in queue at the
start of queueRateCheckTime period. 

Current implementation is problem for cases when messages are sent to queue in bursts, for
example producer sends 1000s messages in a few seconds and then stops and will do that again
in 1 hour. QueueImpl.getRate() method returns 0 msg/s for slow consumer check period set to
for example 5 min and slow consumer detection will be skipped. 

I tried to fix it by following change to QueueImpl.getRate() method and seems to be ok, wdyt?
{code}
   private final AtomicLong messageCountSnapshot = new AtomicLong(0);
   public float getRate() {
      long locaMessageAdded = getMessagesAdded();
      float timeSlice = ((System.currentTimeMillis() - queueRateCheckTime.getAndSet(System.currentTimeMillis()))
/ 1000.0f);
      if (timeSlice == 0) {
         messagesAddedSnapshot.getAndSet(locaMessageAdded);
         return 0.0f;
      }
      return BigDecimal.valueOf(((locaMessageAdded - messagesAddedSnapshot.getAndSet(locaMessageAdded))
+ messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2, BigDecimal.ROUND_UP).floatValue();
   }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message