Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Wed, 15 Feb 2017 01:12:42 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13042955.1487082102000.82342.1487121162296@Atlassian.JIRA>
In-Reply-To: <JIRA.13042955.1487082102000@Atlassian.JIRA>
References: <JIRA.13042955.1487082102000@Atlassian.JIRA> <JIRA.13042955.1487082102837@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARTEMIS-963) ClassCastException in
 ActiveMQChannelHandler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 15 Feb 2017 01:12:49 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-963?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158=
67039#comment-15867039 ]=20

ASF subversion and git services commented on ARTEMIS-963:
---------------------------------------------------------

Commit be370209641312c270176d7ac552d3f0e54ab555 in activemq-artemis's branc=
h refs/heads/1.x from [~jmesnil]
[ https://git-wip-us.apache.org/repos/asf?p=3Dactivemq-artemis.git;h=3Dbe37=
020 ]

[ARTEMIS-963]=C2=A0Prevent ClassCastException in ActiveMQChannelHandler

When HTTP Upgrade is enabled, update Netty's pipeline only after the
HTTP Upgrade handshake is successful *and* the trailing
EMPTY_LAST_CONTENT is received.
Otherwise, this EMPTY_LAST_CONTENT is handled by
ActiveMQChannelHandler which is only expected to handle ByteBuf

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-963
(cherry picked from commit 992dc2bc1b613dcb788ae2b4d59dc098e3325610)


> ClassCastException in ActiveMQChannelHandler
> --------------------------------------------
>
>                 Key: ARTEMIS-963
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-963
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.2
>            Reporter: Jeff Mesnil
>
> In WildFly, we use Artemis HTTP upgrade to connect from the Artemis clien=
t to the server.
> We also have an older version of Netty (4.0.35.Final) than the one used b=
y Artemis (4.1.5.Final).
> When I upgraded the version of Netty in WildFly to 4.1.5.Final, I found a=
 regression that is causing a ClassCastException in ActiveMQChannelHandler#=
channelRead where I received a Netty's LastHttpContent.EMPTY_LAST_CONTENT i=
nstead of a ByteBuf.
> After some bisect, we found that the actual regression happened with Nett=
y 4.0.37.Final and this PR[1].
> Before Netty 4.0.37.Final, the pipeline was updated in HttpUpgradeHandler=
#channelRead0 when the HttpResponse (corresponding to the HTTP Upgrade 101 =
header). Then the following LastHttpContent.EMPTY_LAST_CONTENT was also con=
sumed by it (but we don't care, the handshake was complete and the latch wa=
s already countdown).
> However, with Netty 4.0.37.Final, the LastHttpContent.EMPTY_LAST_CONTENT =
is now handled after the pipeline was updated and it now received by Active=
MQChannelHandler#channelRead. This causes the ClassCastException as this ha=
ndler is only expecting ByteBuf.
> The code in HttpUpgradeHandler#channelRead0 must be updated so that the p=
ipeline is updated only when the HTTP ugprade handshake is successful *and*=
 we consume the LastHttpContent.EMPTY_LAST_CONTENT that is added by Netty
> [1] https://github.com/netty/netty/pull/5110


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)