Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Tue, 7 Feb 2017 11:06:41 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13036571.1484921887000.15348.1486465601940@Atlassian.JIRA>
In-Reply-To: <JIRA.13036571.1484921887000@Atlassian.JIRA>
References: <JIRA.13036571.1484921887000@Atlassian.JIRA> <JIRA.13036571.1484921887238@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ARTEMIS-931) Improve HTTP upgrade connection
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Feb 2017 11:06:50 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855769#comment-15855769 ] 

ASF subversion and git services commented on ARTEMIS-931:
---------------------------------------------------------

Commit dd052026e6c5616f1f51795ea21d26f12deaf9e7 in activemq-artemis's branch refs/heads/master from [~jmesnil]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=dd05202 ]

[ARTEMIS-931] Fix HTTP Upgrade Connection

* Fix isEquivalent() method to take into account the activemqServerName
  property when httpUpgradeEnabled is true. Two ActiveMQ server hosted on
  the same app server may have the same host and port (corresponding to
  the Web server HTTP port). The activemqServerName property is used to
  distinguish them.
* Iron out HTTP upgrade handler so that the latch is always count down
  and the channel context is closed unless the handshake was completed
  successfully

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-931


> Improve HTTP upgrade connection
> -------------------------------
>
>                 Key: ARTEMIS-931
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-931
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.2
>            Reporter: Jeff Mesnil
>             Fix For: 2.0.0, 1.5.x
>
>
> When Artemis connector is configured to use http-upgrade, it will send an HTTP request to the server to perform the upgrade handshake and wait for response for 30 seconds maximum.
> The code in HttpUpgradeHandler#channelRead0 checks if the received object from the server is a HttpResponse and check its header.
> However if the received object is not an HttpResponse (e.g. a LastHttpContent if the web server is suspended and returns a 404 with a text content), the code does not close the context and does not countdown the latch.
> This results in a 30s block for the client when we already know that the connection will not be possible.
> Improving code in  HttpUpgradeHandler#channelRead0 will remove this 30s wait time and ensure a fast dectection from the client so that it can try to connect to another server for example.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)