activemq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARTEMIS-996) Simplify and deduplicate lookupHome(path) in artemis-maven-plugin
Date Fri, 24 Feb 2017 16:00:46 GMT

    [ https://issues.apache.org/jira/browse/ARTEMIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882961#comment-15882961
] 

ASF subversion and git services commented on ARTEMIS-996:
---------------------------------------------------------

Commit da06be192b190c5c1792cac519e16ed1946a668b in activemq-artemis's branch refs/heads/master
from [~jdanek]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=da06be1 ]

ARTEMIS-996 Simplify what was lookupHome(path) in artemis-maven-plugin and deduplicate it


> Simplify and deduplicate lookupHome(path) in artemis-maven-plugin
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-996
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-996
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.0.0
>            Reporter: Jiri Danek
>            Priority: Trivial
>
> ArtemisCLIPlugin.java and ArtemisCreatePlugin.java in artemis-maven-plugin both contain
the following code
> {noformat}
>  85      Path binFolder = path.resolve("bin");
>  86
>  87      if (binFolder == null && Files.exists(binFolder, LinkOption.NOFOLLOW_LINKS))
{
>  88         return false;
>  89      }
> {noformat}
> Check for null is unnecessary, because Path#resolve never returns null, and also the
condition in if does not make any sense.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message