Mailing-List: contact issues-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
Date: Tue, 31 Jan 2017 20:10:51 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@activemq.apache.org
Message-ID: <JIRA.13035278.1484586820000.1938.1485893451647@Atlassian.JIRA>
In-Reply-To: <JIRA.13035278.1484586820000@Atlassian.JIRA>
References: <JIRA.13035278.1484586820000@Atlassian.JIRA> <JIRA.13035278.1484586820082@jira-lw-us.apache.org>
Subject: [jira] (ARTEMIS-922) Clean up addressing API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 31 Jan 2017 20:10:59 -0000


    [ https://issues.apache.org/jira/browse/ARTEMIS-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847426#comment-15847426 ] 

ASF GitHub Bot commented on ARTEMIS-922:
----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/982#discussion_r98759149
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/addressing/AddressingTest.java ---
    @@ -224,37 +224,30 @@ public void testMulticastRoutingBackwardsCompat() throws Exception {
     
        @Test
        public void testPurgeOnNoConsumersTrue() throws Exception {
    -
           SimpleString address = new SimpleString("test.address");
           SimpleString queueName = SimpleString.toSimpleString(UUID.randomUUID().toString());
    -      // For each address, create 2 Queues with the same address, assert both queues receive message
    -      boolean purgeOnNoConsumers = true;
    -      Queue q1 = server.createQueue(address, RoutingType.MULTICAST, queueName, null, true, false, Queue.MAX_CONSUMERS_UNLIMITED, purgeOnNoConsumers, true);
    -
    +      server.createQueue(address, RoutingType.ANYCAST, queueName, null, null, true, false, false, false, false, 1, true, true);
    +      assertNotNull(server.locateQueue(queueName));
           ClientSession session = sessionFactory.createSession();
    -      session.start();
    -
    -      ClientConsumer consumer1 = session.createConsumer(q1.getName());
    -      consumer1.close();
    -
    -      assertFalse(server.queueQuery(queueName).isExists());
    +      ClientProducer producer = session.createProducer(address);
    +      producer.send(session.createMessage(true));
    +      session.createConsumer(queueName).close();
    --- End diff --
    
    is this really synchronous? don't you need a Wait here?


> Clean up addressing API
> -----------------------
>
>                 Key: ARTEMIS-922
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-922
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>             Fix For: 2.0.0
>
>
> A lot of new methods were added to the broker related to the addressing updates.  Older, deprecated methods should no longer be used within the code-base (e.g. in tests) and some new methods can be simplified/consolidated.  Some methods can be renamed to be more clear.  


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)